feat: separate store from datasource configurations #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -54,7 +59,7 @@ | |||
|
|
|||
| @Provider | |||
| public BusinessPartnerStore sqlStore(ServiceExtensionContext context) { | |||
| var dataSourceName = context.getConfig().getString(DATASOURCE_SETTING_NAME, DEFAULT_DATASOURCE_NAME); | |||
| var dataSourceName = DataSourceName.getDataSourceName(DATASOURCE_NAME, DATASOURCE_SETTING_NAME, context.getConfig(), context.getMonitor()); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
ndr-brt
force-pushed
the
separate-stores-from-datasources
branch
2 times, most recently
from
5b7a123 to
3b93350
Compare
ndr-brt
force-pushed
the
separate-stores-from-datasources
branch
from
3b93350 to
10f2103
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
As done in upstream, this PRs separate store configuration from the datasource one, this way it will be possibile to define and use different datasources for different stores, and by default they will all be brought back to
defaultdatasource.WHY
Briefly state why the change was necessary.
FURTHER NOTES
preparephase, where it should belong.Closes # <-- insert Issue number if one exists